Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Test - Improve tearDown cleanup of domain contacts #20258

Merged
merged 1 commit into from
May 12, 2021
Merged

[NFC] Test - Improve tearDown cleanup of domain contacts #20258

merged 1 commit into from
May 12, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[NFC] Test - Improve tearDown cleanup of domain contacts

Before

createDomainContacts does not ensure the domain contacts have a from_email

After

createDomainContacts does ensure the domain contacts have a from_email

Technical Details

Comments

Trying to iron out test inconsistencies

@civibot civibot bot added the master label May 10, 2021
@civibot
Copy link

civibot bot commented May 10, 2021

(Standard links)

@seamuslee001
Copy link
Contributor

Test fails relate here I believe @eileenmcnaughton

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton force-pushed the tear branch 3 times, most recently from dd939af to 1cb612e Compare May 11, 2021 01:30
@seamuslee001
Copy link
Contributor

@eileenmcnaughton can you rebase?

@colemanw
Copy link
Member

@eileenmcnaughton are you going incognito with your git commits?

@eileenmcnaughton
Copy link
Contributor Author

@colemanw yes I do seem to have acquired an air of mystery

@monishdeb
Copy link
Member

@eileenmcnaughton seems like the test failures are related

@eileenmcnaughton eileenmcnaughton force-pushed the tear branch 2 times, most recently from 8c2a2cf to 46ec5fd Compare May 11, 2021 21:08
@eileenmcnaughton
Improve tearDown cleanup of domain contacts
87fa049 
    Fixes to ensure the domain contacts from addresses are re-instated
@eileenmcnaughton eileenmcnaughton merged commit 139a731 into civicrm:master May 12, 2021
@eileenmcnaughton eileenmcnaughton deleted the tear branch May 12, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eileenmcnaughton @seamuslee001 @colemanw @monishdeb