Afform - Drag & drop fixes

[colemanw]

Overview

Fixes bugs related to dragging and dropping fields in the Afform Admin GUI.

Before

Possible to drag fields outside their fieldsets, breaking the UI.

After

Fields belonging to an entity constrained to fieldsets of that entity.

Technical Details

The drag-drop validation broke when af-gui-field was changed from a directive to a component, as the jQuery was looking for the wrong markup.

Comments

Additionally, this attempts to fix a hard-to-reproduce bug where the styling gets stuck in a "dragging" state after something has been dropped.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I tested this on the PR test site and seems to work but I do not that with my test afform http://core-20263-1xio2.test-1.civicrm.org:8001/civicrm/admin/afform#/edit/afformTestCustomForm I wasn't able to re-order the fields which may be a consequence of this PR but not sure @colemanw

[colemanw]

@seamuslee001 when I followed that link I was able to drag fields around within their own entity's fieldset, but I was not able to drag fields from the Activity fieldset into the Contact's fieldset, which is the goal of this PR. So it seems to be working.

[seamuslee001]

@colemanw I was more thinking reordering the whole field set so that the Activity field set was above that of the Contact, I thought that was possible before

[colemanw]

Oh yea. I see it now. That's not related to this PR, it seems to be a css issue that jQuery sortable doesn't have enough space in the top/bottom margins to drag things into. I'm trying (and getting frustrated) to adjust the css to make jQuery sortable happy. Will try again in the morning.

[seamuslee001]

Merging based on that comment from Coleman