Fix delete customgroup using API4 so it removes data table #20265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using API3 CustomGroup.delete the associated data table is also deleted via a special function
deleteGroup()
But with API4 it is not because it's using the generic delete handling. This PR extends that so that the associated data table is deleted when called via API4.Before
Custom group data table not deleted on API4 CustomGroup.delete
After
Custom group data table deleted on API4 CustomGroup.delete
Technical Details
Comments
@colemanw Does this make sense?