Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete customgroup using API4 so it removes data table #20265

Merged
merged 2 commits into from
May 11, 2021

Conversation

mattwire
Copy link
Contributor

Overview

When using API3 CustomGroup.delete the associated data table is also deleted via a special function deleteGroup() But with API4 it is not because it's using the generic delete handling. This PR extends that so that the associated data table is deleted when called via API4.

Before

Custom group data table not deleted on API4 CustomGroup.delete

After

Custom group data table deleted on API4 CustomGroup.delete

Technical Details

Comments

@colemanw Does this make sense?

@civibot
Copy link

civibot bot commented May 10, 2021

(Standard links)

@civibot civibot bot added the master label May 10, 2021
@mattwire mattwire force-pushed the api4customgroupdelete branch from 5cfe152 to a4fc91e Compare May 10, 2021 19:28
@mattwire
Copy link
Contributor Author

Thanks @colemanw I agree with your suggestion and have updated.

@colemanw
Copy link
Member

I added a failing test and pushed it to this PR, so now if tests pass, we're good.

@seamuslee001 seamuslee001 merged commit b10b55d into civicrm:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants