User experience improvement - Remove the confusing mixed terminology used to describe Tags: "Tags (Categories)" and "Tag (Category)"

[agileware-justin]

Overview

Remove the confusing mixed terminology used to describe Tags: "Tags (Categories)" and "Tag (Category)".
This comes up during CiviCRM training as questions like: "What's a Category? And what's the difference between Tags and Categories? Where are the Categories?".
This is a small user experience improvement.

Before

Confusing mixed terminology used to describe Tags: "Tags (Categories)" and "Tag (Category)"

After

Removed "(Categories)" and "(Category)" from the menu.

Technical Details

SQL update task added to CRM/Upgrade/Incremental/sql/5.39.alpha1.mysql.tpl - don't know if this is the way to do it, just a guess.

Comments

Agileware Ref: CIVICRM-1725

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@agileware-justin are you able to make those changes suggested by @demeritcowboy? He is correct that when updating labels in the UI, as a general rule it's not a good idea to update the machine names (even if those names are really dumb).

[agileware-justin]

@colemanw done

[colemanw]

Ok this still needs regen.sh run.

[demeritcowboy]

Justin said he was unable to run regen, but my thinking is a direct file edit would be fine here since no ids are changing.

[colemanw]

I guess I'm not 100% clear on what needs updating. This PR affects both the civicrm_navigation and civicrm_menu tables, and I think the menu item gets its name from the <title> which means that would be updating as well?

[agileware-justin]

@demeritcowboy I've added the sql/civicrm_generated.mysql you provided here (thanks), master...demeritcowboy:20268-2

Not sure why the bot is failing the build now. Any ideas?

[demeritcowboy]

The link in your comment is correct but it looks like it's the earlier patch that's in this PR?

[agileware-justin]

@demeritcowboy thanks for the Regen workflow, that's super handy. Regen'd SQL file updated to PR.

[demeritcowboy]

Thanks for sticking with it just it's still changing the name field too instead of just the label - at https://github.com/civicrm/civicrm-core/pull/20268/files#diff-3cb0940fe7330143f6ceda4325b73ebf7ed700e55d987606ccd1ff45ab35eab7L98

and

https://github.com/civicrm/civicrm-core/pull/20268/files#diff-3cb0940fe7330143f6ceda4325b73ebf7ed700e55d987606ccd1ff45ab35eab7L295

[agileware-justin]

Thanks for sticking with it just it's still changing the name field too instead of just the label

Right, because of this previous comment, gotcha.

I don't think name should be updated. It would be label to update. If we could go back in time to around 2009 the name field should really be called internalLookupKey or machineName and have its value be an integer or something obviously used as a fixed key and not for display.

[demeritcowboy]

Yay!
There's no appropriate label in github to categorize this with so I'll just leave it untagged.

[agileware-justin]

It's handy to tag which CiviCRM release it'll be included with.

[agileware-justin]

Thanks for your help @demeritcowboy in getting this one over the line. Such a simple change, so many hoops.