[REF] Make use of recently added default pager size setting in Reports #20273
Conversation
|
(Standard links)
|
CRM/Report/Form.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| public function limit($rowCount = self::ROW_COUNT_LIMIT) { | ||
| public function limit($rowCount = NULL) { | ||
| if (CRM_Utils_System::isNull($rowCount)) { |
There was a problem hiding this comment.
I see isNull isn't deprecated yet but it does unexpected things sometimes. Was this copy/paste or is there a reason to use it?
There was a problem hiding this comment.
I was wanting to get the function if $rowCount was NULL rather than say 0 had been passed into the function
There was a problem hiding this comment.
In php 7.4 there's a nifty $rowCount ??= $this->getRowCount();. For php 7 in general could do $rowCount = $rowcount ?? $this->getRowCount(); or there's regular is_null().
CRM/Report/Form.php
Outdated
| /** | ||
| * Class constructor. | ||
| */ | ||
| public function __construct() { | ||
| parent::__construct(); | ||
|
|
||
| $this->setRowCount(\Civi::settings()->get('default_pager_size') ?? 50); |
There was a problem hiding this comment.
It shouldn't be necessary to specify ?? 50 since settings() knows to take it from the file definition so it only needs to be in one place.
Update code as per feedback from Dave D
seamuslee001
force-pushed
the
report_default_pager
branch
from
1d3434a to
11630f6
Compare
|
@demeritcowboy I believe I have updated this to what you wanted now |
Overview
This makes use of the recently added default_pager_size setting in reports
Before
Constant used, no reference to setting
After
Setting used
ping @demeritcowboy @colemanw