Fix CKEditor5 link editing in modal dialog #20285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Oh wow - I totally didn't expect that to be a core fix |
|
Some of this low-level configuration stuff in jQuery UI can only be overridden once. It's not a hook or event that an extension can subscribe to. |
|
On my initial testing this is looking good |
|
This works for me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes https://lab.civicrm.org/extensions/ckeditor5/-/issues/4
Before
Editing links broken for wysiwyg within popup dialog.
After
Fixed.
Technical Details
See https://api.jqueryui.com/dialog/#method-_allowInteraction