[REF] Provide standardised methods to get recurring contribution id & object #20294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -611,16 +644,6 @@ public function handlePaymentExpress() { | |||
| throw new CRM_Core_Exception('Failure: Could not find contribution record for ' . (int) $contribution->id, NULL, ['context' => "Could not find contribution record: {$contribution->id} in IPN request: " . print_r($input, TRUE)]); | |||
| } | |||
|
|
|||
| if (!empty($ids['contributionRecur'])) { | |||
There was a problem hiding this comment.
this object is actually not used... it is a sort of validation that has been copied & pasted - but the getsingle above already does this validation
… object This adds methods to get the recurring contribution id & object that work from the paypal express and from the paypal pro flows. In the paypal express flow it is retrieved from a known value (and this flow is only ever hit for recurrings as evidenced by the existing getsingle) and then set on the class. For paypal pro it is optional and will be in the cheap-to-access POST array if relevant
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
May 17, 2021
…sed param This is a follow up to civicrm#20294 - getContributionRecurID now always has the id so we don't need to pass it around in the ids array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Provide standardised methods to get recurring contribution id & object
Before
values passed around
After
reliable methods to retrieve them that work for both paypal pro and paypal express
Technical Details
This adds methods to get the recurring contribution id & object that work from the paypal
express and from the paypal pro flows. In the paypal express flow it is
retrieved from a known value (and this flow is only ever hit for recurrings
as evidenced by the existing getsingle) and then set on the class. For paypal pro
it is optional and will be in the cheap-to-access POST array if relevant
Comments
tests in
CRM_Core_Payment_PayPalProIPNTest