[REF] Extract function to build temporary table of members of group from Report_Form #20297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@seamuslee001 can you merge this one? The test fail was because I'd made a small change in extracting which I've changed back now so this is a pretty straight extraction now. Also, test cover is good :-) |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Extract function to build temporary table of members of group from Report_Form
Before
Code on Report_Form
After
Code on GroupContactCache, ready for further work
Technical Details
Test cover in the ReportTemplateTest class
Comments
I spotted a flaw in the code around parents not being resolved. Next fix will address.