get county fields populated via api call

[jmcclelland]

Ensure that county fields are properly populated when
calling the Profile.getfields api.

Overview

The Profile.getfields with api_action=submit API helps re-use CiviCRM profiles in other contexts by providing details on all the fields in the profile. Unfortunately, county is left out! This change ensures that the county field is included.

Before

When calling the API: Profile.getfields api_action=submit get_options=all profile_id=NNN on a profile that includes the county field, the county field is not fully populated.

After

After this change, the county field is populated.

Comments

This is a tiny change that I hope won't have any nasty repercussions. I know that api3 is being left in the dust, but this teeny fix really helps the remoteform extension live a little longer.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@jmcclelland so I guess this is OK - my only worry would be performance but that would only be an issue if county is in the profile?

[jmcclelland]

@eileenmcnaughton Yes, that's my impression. If county is not in the profile, it should have no effect and no performance hit. The only surprise should be for people who had county in their profile and figured out some work around to make it work with this API call. But, I suspect that will be just about nobody.

[eileenmcnaughton]

OK