Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct copy-paste error in CustomField schema #20329

Merged
merged 1 commit into from
May 17, 2021

Conversation

highfalutin
Copy link
Contributor

Before: in API4 explorer and elsewhere, the description for CustomField.name is a verbatim copy of CustomGroup.name -- this is incorrect

After: description correctly refers to "field"

@civibot
Copy link

civibot bot commented May 17, 2021

(Standard links)

@civibot civibot bot added the master label May 17, 2021
@eileenmcnaughton
Copy link
Contributor

Well spotted @highfalutin - this is so trivial I'm happy just merge as is & let the DAO get fixed 'when it does' - but to make this change show up you will need to run GenCode.php (I run it by going into the xml dir & running php Gencode.php although I think @seamuslee001 has a more recommended way - it might even be documented).

I'll merge this & you can put that up as a patch now or it can happen when it happens

@eileenmcnaughton eileenmcnaughton merged commit 81e1f97 into civicrm:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants