Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core_DAO - fire links_callback for all entities #20332

Merged
merged 1 commit into from
May 18, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 17, 2021

Overview

CRM_Core_DAO has a fallback getReferenceColumns for entities with no foreign key fields. That function was empty, so did not run the callbacks which are called by most other DAOs' getReferenceColumns.

Before

Fallback function did not call createReferenceColumns or fire links_callback

After

createReferenceColumns always called and links_callback always fired for any DAO::getReferenceColumns().

…plicitly declare links

CRM_Core_DAO has a fallback function for entities with no foreign key fields.
Previously, that function did not call createReferenceColumns or fire links_callback
@civibot
Copy link

civibot bot commented May 17, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

OK - this feels like it would be safe because the other DAOS already do it - I think if there are no jenkins issues it's all good.

My worry was whether there could be any order issues - but Domain BAO already calls this hook & that would be one of the earliest to be intantiated

@seamuslee001 seamuslee001 merged commit 5aaffe0 into civicrm:master May 18, 2021
@seamuslee001 seamuslee001 deleted the links_callback branch May 18, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants