Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2403 - Change Greenwich link color from gray to blue #20341

Merged
merged 1 commit into from
May 18, 2021

Conversation

colemanw
Copy link
Member

Overview

Fixes a styling issue in Greenwich which made it difficult to tell links apart from plain text.
See https://lab.civicrm.org/dev/core/-/issues/2403

Before

image

After

image

Technical Details

Uses link color from civicrm.css

@civibot
Copy link

civibot bot commented May 18, 2021

(Standard links)

@civibot civibot bot added the master label May 18, 2021
@demeritcowboy
Copy link
Contributor

demeritcowboy commented May 18, 2021

This doesn't seem to work for me? It gets overridden by #bootstrap-theme a (or maybe not overridden - but that's what's being used).

But +1 on changing it to something that's not invisible.

@demeritcowboy
Copy link
Contributor

Or is there another step I need to do - I ran composer install and it appeared to compile it, but I'm not sure it actually did

Compile: Generate CCL wrapper functions
Compile: Greenwich CSS (dist/bootstrap3.css)

But my dist/boostrap3.css is still from May 4, which might be the last time I updated this particular install.

@demeritcowboy
Copy link
Contributor

Ok ignore me. Some kind of cache problem even though I had cleared cache. I cleared it again and it works!

@eileenmcnaughton eileenmcnaughton merged commit b0b83bf into civicrm:master May 18, 2021
@eileenmcnaughton eileenmcnaughton deleted the greenwichLinkColor branch May 18, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants