Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compact][phpunit8][NFC] Remove timecop function references from Cache Tiered Test #20343

Merged
merged 1 commit into from
May 19, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This removes the last usage of timecop from CiviCRM unit testing

Before

Timecop used if it is available

After

Timecop not used

ping @totten

@civibot
Copy link

civibot bot commented May 18, 2021

(Standard links)

@civibot civibot bot added the master label May 18, 2021
@totten
Copy link
Member

totten commented May 19, 2021

Thanks @seamuslee001.

So I think the only impact will be that testTieredTimeout_explicitHigh_lateReoad will run 5 seconds slower - which, for this one E2E test, seems worth it (if it means that we can remove this question from PHP8 support-path).

r-test passes, so let's do it...

@totten totten merged commit 9610e4d into civicrm:master May 19, 2021
@seamuslee001 seamuslee001 changed the title [NFC] Remove timecop function references from Cache Tiered Test [php8-compact][phpunit8][NFC] Remove timecop function references from Cache Tiered Test May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants