dev/core#2613 - Replace deprecated function in useradd task

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2613

Before

1. Use 5.36 or earlier, or the latest master, and not wordpress.
2. Log in as a user with user creation rights.
3. View a contact.
4. From the actions menu choose Create User Record.
5. Fill it out and save.
6. Deprecated function: Function create_function() is deprecated...

After

1. No warning.

Technical Details

It's deprecated in php 7.2 and will be removed in php 8. This is the only place the quickform 'compare' formrule is used, and it's kind of a weird function, so rather than try to fix it, just use a regular formRule.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass

[demeritcowboy]

Thanks!