SearchKit and Afform UI improvements #20348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Test fail relates |
|
@colemanw I reviewed the PR here and it works, I think you just need to remove the unsetting of created_date to fix the test failure. |
Previously, limit was a number input which could be disabled by entering the number '0'. That's less intuitive than a checkbox.
The trailing colon is a pain for translators.
When saving a search, the modified_date was being overwritten with the old value.
|
@seamuslee001 I think we're not very consistent about whether or not we allow calculated fields such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleans up the admin UI for SearchKit and Afform, adds click-to-sort table headers and fixes a bug where SavedSearch modified_date was not being saved.