Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Update PHPUnit config to not cache results in phpunit8 and add … #20356

Merged
merged 1 commit into from
May 20, 2021

Conversation

seamuslee001
Copy link
Contributor

…more voids into PayflowProTest

Overview

Title says it all

Before

Tests results cached in phpunit8

After

No caching of tests results in phpunit8

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented May 20, 2021

(Standard links)

@civibot civibot bot added the master label May 20, 2021
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 do you have a good link to the meaning of the new option? (I can google but wondered if you had found one that is 'good')

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 that seems OK - there are some follow ups to civix we probably need to do and also to add the .phpunit.result.cache to gitignore so people don't add it by mistake - since they could run it differently locally

However, I don't think those are blocking on merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants