Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bulkSave test to use the api #20362

Merged
merged 1 commit into from
May 20, 2021
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 20, 2021

Overview

Update bulkSave test to use the API

Before

Test uses internal function

After

Test uses the API

Technical Details

@colemanw I think this makes more sense now

Comments

@civibot
Copy link

civibot bot commented May 20, 2021

(Standard links)

@civibot civibot bot added the master label May 20, 2021
@eileenmcnaughton eileenmcnaughton changed the title Update bulkSave test to use the UI Update bulkSave test to use the api May 20, 2021
@colemanw
Copy link
Member

@eileenmcnaughton this looks good now. Are we ready for CRM_Core_BAO_CustomField::bulkSave to emit a deprecation warning? Or are any of your extensions using it?

@eileenmcnaughton
Copy link
Contributor Author

@colemanw we might be using it - but I don't see that as blocking deprecation

@colemanw colemanw merged commit ac45274 into civicrm:master May 20, 2021
@eileenmcnaughton eileenmcnaughton deleted the save branch May 20, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants