Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Useradd contact task - Use OO instead of hardcoding "if Wordpress" #20366

Merged
merged 1 commit into from
May 20, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

This should be no change from current - putting it up while it's still in recent memory.

Before

  1. Log in as a user who can create users in the CMS.
  2. Visit a contact record.
  3. From the actions dropdown choose Create User Record.
  4. On all CMS's except wordpress there'll be a password field.
  5. On wordpress it depends if users can register.

After

Same

Technical Details

Just refactors so that it isn't "if Wordpress" and instead uses the class hierarchy.

Comments

@civibot
Copy link

civibot bot commented May 20, 2021

(Standard links)

@civibot civibot bot added the master label May 20, 2021
@seamuslee001
Copy link
Contributor

looks good to me merging

@seamuslee001 seamuslee001 merged commit 2b6d4ea into civicrm:master May 20, 2021
@demeritcowboy demeritcowboy deleted the more-oo branch May 21, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants