Use PHPUnit8 in main test suites #20370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
phpunit8
branch
8 times, most recently
from
d6e4011 to
974da36
Compare
seamuslee001
changed the title
|
Jenkins re test this please now without any blockers @eileenmcnaughton this should work fine (I had manually applied the buildkit patch but just to the PR testing not to anything else) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This makes phpunit8 the default test runner for php versions greater than 7.2 for the core test suites
Before
PHPUnit7 used as the default
After
PHPUnit8 used as default
Technical Details
To make this work for Jenkins reasons we need this PR civicrm/civicrm-buildkit#626 (comment) or to upgrade xunit
ping @eileenmcnaughton @totten