Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] [Test] Preliminary cleanup in test class #20371

Merged
merged 1 commit into from
May 21, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 20, 2021

Overview

[NFC] [Test] Preliminary cleanup in test class

Before

Grumpy IDE

After

It's camomile tea for the stressed IDE

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 20, 2021

(Standard links)

@civibot civibot bot added the master label May 20, 2021
@@ -31,14 +30,20 @@ class api_v3_TaxContributionPageTest extends CiviUnitTestCase {
protected $halfFinancialAccId;
protected $halfFinancialTypeId;

protected $isValidateFinancialsOnPostAssert = FALSE;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as the parent - I want to switch to TRUE but there is a bug to track down first - I don't know if it is a test bug or a live bug

@eileenmcnaughton eileenmcnaughton merged commit 91b8545 into civicrm:master May 21, 2021
@eileenmcnaughton eileenmcnaughton deleted the tax branch May 21, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants