[REF] extract function to get locks

[eileenmcnaughton]

Overview

[REF] extract function to get locks

Before

The load() function is the heart of the groupContactCache - but other functions work quite hard to call it because it accepts a BAO as a parameter in order to get a single group ID. This extracts part of the function into a more re-usable chunk

After

Sadly a lot of indentation change - use w=1 to view

This is part of trying to make the logic more re-usable and make the
way of dealing with a single group more aligned with dealing with
multiple groups in this class

Technical Details

Comments

Test cover in CRM_Contact_BAO_GroupContactCacheTest - testManualAddRemove is a good one to step through the code via

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This seems fine to me