[NFC] Fix PHPUnit8 Deprecation Warnings in api_v3 and Civi Test Suites #20380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
api_v3_civi_phpunit8_warnings
branch
from
61603a1 to
44c312c
Compare
| @@ -3026,7 +3026,7 @@ public function testContactCreationPermissions($version) { | |||
| $config = CRM_Core_Config::singleton(); | |||
| $config->userPermissionClass->permissions = ['access CiviCRM']; | |||
| $result = $this->callAPIFailure('contact', 'create', $params); | |||
| $this->assertContains('failed', $result['error_message'], 'lacking permissions should not be enough to create a contact'); | |||
There was a problem hiding this comment.
@seamuslee001 can we hold off this PR until the one that I have on this file is merged - since it's a fairly large challenging cleanup on this file & I don't want this to make it stale once it is passing
seamuslee001
force-pushed
the
api_v3_civi_phpunit8_warnings
branch
2 times, most recently
from
0a3c66b to
65b1032
Compare
|
@eileenmcnaughton I believe your other one has been merged now |
seamuslee001
force-pushed
the
api_v3_civi_phpunit8_warnings
branch
from
65b1032 to
1bae74d
Compare
seamuslee001
force-pushed
the
api_v3_civi_phpunit8_warnings
branch
from
1bae74d to
a12620a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Warnings show about deprecated test methods
Before
Warnings show
After
No Warnings
ping @eileenmcnaughton