[NFC] {test} code cleanup in test class #20389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
| @@ -236,7 +239,6 @@ public function testCreateCheckContribution() { | |||
| $params['amount_level'] = 'Unreasonable'; | |||
| $params['cancel_reason'] = 'You lose sucker'; | |||
| $params['creditnote_id'] = 'sudo rm -rf'; | |||
| $params['tax_amount'] = '1'; | |||
There was a problem hiding this comment.
This is removed because the test operates with tax disabled so it is not valid to have a tax_amount for this contribution
| public function testCreateContributionSourceInvalidContContact() { | ||
|
|
||
| $params = [ | ||
| 'contribution_contact_id' => 999, |
There was a problem hiding this comment.
We have adequate cover for using an invalid contact id in syntax conformance - in general these failure tests have been rationalised from the early days
| public function testDeleteParamsNotArrayContribution() { | ||
| $this->expectException(TypeError::class); | ||
| $params = 'contribution_id= 1'; | ||
| $contribution = $this->callAPIFailure('contribution', 'delete', $params); |
There was a problem hiding this comment.
This is adequately covered in syntax conformance & with array typing
|
|
@seamuslee001 I think that is already fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[NFC] {test} code cleanup in test class
Before
Loads of bad practice
After
IDE mental state much improved
Technical Details
Comments