Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arguments sent to hook_civicrm_check #20400

Merged
merged 1 commit into from
May 24, 2021

Conversation

MegaphoneJon
Copy link
Contributor

@MegaphoneJon MegaphoneJon commented May 24, 2021

Overview

The signature for hook_civicrm_check was changed at some point to take three arguments instead of one, per the docs. However, only one argument is passed to the hook.

Before

Error when you defined a hook_civicrm_check per the docs:

  [Symfony\Component\Debug\Exception\FatalThrowableError]                                                                                                                                                             
  Type error: Too few arguments to function monitoring_civicrm_check(), 1 passed in /mysite.org/vendor/civicrm/civicrm-core/CRM/Utils/Hook.php on line 271 and exactly 3 expected  

After

All better.

Technical Details

Looks like an oversight on #17824. It should be clear from the line preceding my change what the reason for the change is.

@civibot
Copy link

civibot bot commented May 24, 2021

(Standard links)

@civibot civibot bot added the master label May 24, 2021
@colemanw colemanw merged commit 8516612 into civicrm:master May 24, 2021
@colemanw
Copy link
Member

Agree it was an oversight. Thanks for the fix.

@MegaphoneJon MegaphoneJon deleted the check-signature branch May 24, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants