Fix contribution page pledge tests to create valid contributions #20404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue where they were using a contribution page with a price set but te submit params were not valid for that price set
|
(Standard links)
|
| @@ -1795,26 +1793,26 @@ public function testSubmitPledgePaymentPaymentProcessorRecurFuturePayment() { | |||
|
|
|||
| // Check if pledge created. | |||
| $pledge = $this->callAPISuccess('pledge', 'getsingle', []); | |||
| $this->assertEquals(date('Ymd', strtotime($pledge['pledge_start_date'])), date('Ymd', strtotime("+1 month"))); | |||
| $this->assertEquals($pledge['pledge_amount'], 300.00); | |||
| $this->assertEquals(date('Ymd', strtotime($pledge['pledge_start_date'])), date('Ymd', strtotime('+1 month'))); | |||
There was a problem hiding this comment.
The configured value just happens to be 30 rather than 300 - change tests to match
| $this->assertEquals(1, $pledgePayment[2]['status_id'], 'This pledge payment should have been completed'); | ||
| $this->assertEquals($contribution['id'], $pledgePayment[2]['contribution_id']); | ||
| $this->assertEquals($pledgePayment[2]['contribution_id'], $contribution['id']); |
There was a problem hiding this comment.
@eileenmcnaughton wasn't this around the right way before?
There was a problem hiding this comment.
Yeah maybe - can I fix that as a follow up?
There was a problem hiding this comment.
as long as you promise to do so
There was a problem hiding this comment.
I've added it into #20402
|
This all seems fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix contribution page pledge tests to create valid contributions
Before
configured contribution page is a price set page but amount being passed instead of price set params
After
price set params passed
Technical Details
Comments