Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eventcart test to only test payment form #20405

Merged
merged 1 commit into from
May 25, 2021

Conversation

mattwire
Copy link
Contributor

Overview

There are two forms in the "checkout" phase of the eventcart. One which selects payments and prices and the final one which is the checkout where payment is taken.
The original implementation incorrectly set participants to "registered" on the first form while the refactored version uses Order API and correctly sets them to "Pending in Cart" until payment is taken when they are updated to Registered.

This updates the test to only check the "registered" status on completion of the second checkout (payment) form and will pass with both original and new implementations.

Before

Participants set as registered before payment, test validating that happens.

After

Test validating that participant is "registered" once payment has been made.

Technical Details

Explained above. Test change only.

Comments

@civibot
Copy link

civibot bot commented May 24, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

seems fine

@seamuslee001 seamuslee001 merged commit 21161c1 into civicrm:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants