Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform GUI - Fix tab breakage in Shoreditch theme #20416

Merged
merged 1 commit into from
May 27, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 25, 2021

Overview

Fix layout breakage when using Shoreditch theme.

Before

image

After

image

Comments

I dunno why Shoreditch css adds extra padding. Maybe for the API explorer?

@civibot
Copy link

civibot bot commented May 25, 2021

(Standard links)

@seamuslee001 seamuslee001 self-assigned this May 25, 2021
@seamuslee001
Copy link
Contributor

@colemanw what version of shoreditch are you using? I am trying on the latest master and I use the standard Garland theme and have a left hand sidebar maybe that is a thing

shoreditch-afform

@colemanw
Copy link
Member Author

@seamuslee001 I'm using the latest master with Seven theme.

@seamuslee001
Copy link
Contributor

I was able to replicate it this time using the Seven theme, I would say this is an improvement but I did find when using Garland theme (which is what I believe the PR test sites are built with) that when you have 3 entities as per the screenshot there is a bit of a gap that is created, However I think this is better in than out merging

afform-tab-style-issue

@seamuslee001 seamuslee001 merged commit 0964308 into civicrm:master May 27, 2021
@seamuslee001 seamuslee001 deleted the afformTabFix branch May 27, 2021 08:45
@colemanw
Copy link
Member Author

colemanw commented May 27, 2021

Thanks @seamuslee001 - here's a followup fix for Garland theme: #20431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants