dev/core#2593 Fully remove loadRelatedObjects from PaypalExpress #20422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton are there any unit tests on paypal express ipn? |
|
2 in the PaypalProIPN class
|
|
Actually 4 - these 2 too |
|
That gives me confidence this is fine merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2593 Fully remove loadRelatedObjects from PaypalExpress
Before
Lots of code in paypal express that was used to support the recur() function but is now no longer required
After
poof
Technical Details
@seamuslee001 this would be the last change touching the Paypal express side of things as https://lab.civicrm.org/dev/core/-/issues/2593 would now be fixed for paypal express
Comments