-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchKit - Add static groups and organize main entity selector #20434
Conversation
(Standard links)
|
@colemanw api.v4.Action.FkJoinTest.testBridgeJoinTags |
This changes the 'bridge' metadata property to a multi-dimensional array to hold extra info like description.
In preparation for showing different tiers of entities, make this a string instead of a boolean property, to mark searchability as 'primary', 'secondary', or 'none'.
… reusability in SearchKit
Adds a collapsed optgroup for secondary entities so they are available but not as prominent as the commonly-searched primary entities.
So I like what you have done on organising the main selector I think it needs to be documented - probably in this page |
@colemanw I have a couple of comments - I'm OK with this being merged & those things being addressed as follow ups - as long as they are |
Re docs - it might make more sense to add a new search kit section - the bridge entity and the primary secondary stuff need documenting - I did test that for existing entities without primary/secondary defined they defaulted to secondary. I didn't test the changes to bridge entities as these seemed to be only used in core and they still work in core - eg contributions with payments listing |
Yes I thought "Secondary" was a good default, since extension authors won't necessarily think about it when they add a new entity. |
Overview
Adds static (non-smart) groups to SearchKit, and organizes main entity selector to be less cluttered, with primary entities up top and the rest within a collapsible optgroup.
Comments
I started doing the declutter work because selecting a group join is confusing. There are currently 3 ways to join on group (created by, modified by, plus the actual join on GroupContact which is the one 99% people want to use over the other two). That circled my mind back to a previous conversation about basic vs advanced modes, and I thought a collapsible optgroup would help a lot towards that end.
In this PR I didn't get as far as organizing the join selectors, so far the declutter just applies to the main entity selector, but it's a start and this PR is getting quite large, so it'd be good to get it merged and I'll keep at it...