Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Extract code to transfer groups from temp table to cache #20435

Merged
merged 1 commit into from
May 28, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 28, 2021

Overview

[REF] Extract code to transfer groups from temp table to cache

This continues efforts to have the 'worker functions' accept an
array of groups, not just a single

Before

code within a loop in the load function

After

Code in it's own function

Technical Details

A gazillion tests run through this

Comments

This continues efforts to have the 'worker functions' accept an
array of groups, not just a single
@civibot
Copy link

civibot bot commented May 28, 2021

(Standard links)

@civibot civibot bot added the master label May 28, 2021
@colemanw
Copy link
Member

Looks like the existing tests would all be passing this function a single value for group id. At some point we'll need to test multiple groups but we'll probably do that as part of APIv4 work.

@colemanw colemanw merged commit ff2fb35 into civicrm:master May 28, 2021
@colemanw colemanw deleted the gg branch May 28, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants