[php8-compat] [REF] Fix call to function CRM_Utils_String::createRandom by ensuring that … #20441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the length is the first parameter not 2nd
|
(Standard links)
|
eileenmcnaughton
changed the title
|
@seamuslee001 I'm adding [php8-compat] to these (which is what I think you are working on with this) so I can link to them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the length is the first parameter not 2nd
Overview
As per the function sig the parameters in the function call are the wrong way around https://github.com/civicrm/civicrm-core/blob/master/CRM/Utils/String.php#L669
Before
Function called with parameters the wrong way around
After
Parameters passed through in the correct way around
ping @eileenmcnaughton @totten