Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compat] Update Various Symfony components to latest version in … #20444

Merged
merged 1 commit into from
May 29, 2021

Conversation

seamuslee001
Copy link
Contributor

…the 3.4.x series to fix deprecation notice around libxml entity disable

Overview

Title says it all

Before

PHP Deprecation notices show in cli when running unit tests on php8.0

After

No deprecation notice from symfony packages note that we are going from v3.4.40 to 3.4.47 change log is here https://github.com/symfony/symfony/blob/3.4/CHANGELOG-3.4.md

ping @eileenmcnaughton @totten @MikeyMJCO

…the 3.4.x series to fix deprecation notice around libxml entity disable
@civibot
Copy link

civibot bot commented May 29, 2021

(Standard links)

@civibot civibot bot added the master label May 29, 2021
@seamuslee001
Copy link
Contributor Author

Test fail looks to be unrelated to me

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 shouldn't we go to 3.4.49 - which includes a couple of recent security fixes? I think changing within 3.4.x is pretty safe but I think the latest in that makes sense

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton seems as tho they aren't in packagist for some reason the last one in packagist is 3.4.47 https://packagist.org/packages/symfony/filesystem#v3.4.47

@seamuslee001
Copy link
Contributor Author

I've filed an issue in the symfony land on this symfony/symfony#41445

@seamuslee001
Copy link
Contributor Author

as per the symfony ticket they are only tagging new releases for the components that actually change so for these the most recent release is 3.4.47 then

@eileenmcnaughton
Copy link
Contributor

OK cool

@eileenmcnaughton eileenmcnaughton merged commit e582e9d into civicrm:master May 29, 2021
@eileenmcnaughton eileenmcnaughton deleted the upgrade_symfony branch May 29, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants