Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compat] Upgrade PHPWord Package to support php8 #20449

Merged
merged 1 commit into from
May 30, 2021

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented May 30, 2021

Overview

This Upgrades PHPWord Package to be 0.18.0 to fix compatibility issues with php8

Before

Library version not fully compatible with php8

After

Library is compatible with php8 and earlier versions of php to php7.0 at least

Technical Details

PHPWord has dropped its requirement of using phpoffice/common package so hence the dropping of the patch for that package and also the phpword package patch was included in the upstream PHPOffice/PHPWord#1585

@civibot
Copy link

civibot bot commented May 30, 2021

(Standard links)

@civibot civibot bot added the master label May 30, 2021
@eileenmcnaughton
Copy link
Contributor

Do you have any idea how to check losing the patch is OK?

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton as per PHPOffice/PHPWord#1585 it was released as part of phpword 0.17.0 and phpword has now dropped the requirement of using phpoffice/common hence the dropping of that patch

@seamuslee001 seamuslee001 changed the title [WIP][php8-compat] Upgrade PHPWord Package to support php8 [php8-compat] Upgrade PHPWord Package to support php8 May 30, 2021
@eileenmcnaughton
Copy link
Contributor

ok - so that issue seems to have primarily impacted tests & I see the common package is gone here https://github.com/civicrm/civicrm-core/pull/20449/files#diff-f37acfaa6b11f575a9a6f41a75fa73a61d0f8ebc2c9b8cddc215d8aca10e44f5L1944 so OK

@eileenmcnaughton eileenmcnaughton merged commit c680b32 into civicrm:master May 30, 2021
@eileenmcnaughton eileenmcnaughton deleted the phpword_upgrade branch May 30, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants