Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DOMPDF to ~1.0.0 #20465

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Bump DOMPDF to ~1.0.0 #20465

merged 2 commits into from
Jun 1, 2021

Conversation

homotechsual
Copy link
Contributor

@homotechsual homotechsual commented Jun 1, 2021

Having reviewed the changelogs and actual changes here https://github.com/dompdf/dompdf/releases and following a run-test on this I can't find any broken functionality as a result of this upgrade.

There are numerous fixes and improvements in this and the next planned version 1.0.3 will further improve SVG handling.

Overview

Update DOMPDF from ~0.8 to ~1.0.0.

Before

What is the old user-interface or technical-contract (as appropriate)?
Using the older 0.8.6 release of DOMPDF.

After

What changed? What is new old user-interface or technical-contract?
Using the new 1.0.2 release of DOMPDF.

Having reviewed the changelogs and actual changes here https://github.com/dompdf/dompdf/releases and following a run-test on this I can't find any broken functionality as a result of this upgrade.

There are numerous fixes and improvements in this and the next planned version 1.0.3 will further improve SVG handling.
@civibot
Copy link

civibot bot commented Jun 1, 2021

(Standard links)

@civibot civibot bot added the master label Jun 1, 2021
@seamuslee001
Copy link
Contributor

@MikeyMJCO no update to the composer.lock file?

@homotechsual
Copy link
Contributor Author

Whoops!

@homotechsual
Copy link
Contributor Author

@MikeyMJCO no update to the composer.lock file?

Done!

@seamuslee001
Copy link
Contributor

I tested this on the PR test site all looks good to me merging

@seamuslee001 seamuslee001 merged commit eccc714 into civicrm:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants