APIv4 Entity.get refactor to be more efficient #20470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Makes APIv4
Entity.get
more efficient.Technical Details
APIv4
Entity.get
no longer does a file scan when getting one or more entities by name.Also deprecates the
includeCustom
param which was redundant with thewhere
clause.This is the first APIv4 param to be deprecated - added handling to emit a warning when using a deprecated param and hide deprecated params in the APIv4 explorer.
Comments
This PR doesn't go as far as to add caching because there wasn't consensus that it would actually help.