[php8-compat] Fix deprecation error where by required function parame…

[seamuslee001]

…ter follows an optional function parameter

Overview

This aims to fix the following php8 deprecations

Deprecated: Required parameter $status follows optional parameter $batchIds in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Batch/BAO/Batch.php on line 620

Deprecated: Required parameter $settingsToReturn follows optional parameter $domains in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Core/BAO/Setting.php on line 99

Deprecated: Required parameter $module follows optional parameter $setDefault in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Contribute/BAO/ContributionPage.php on line 834

Deprecated: Required parameter $userID follows optional parameter $type in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Case/BAO/Case.php on line 403

Deprecated: Required parameter $userID follows optional parameter $type in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Case/BAO/Case.php on line 416

Deprecated: Required parameter $caseId follows optional parameter $attachments in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Case/BAO/Case.php on line 1261

Deprecated: Required parameter $contact follows optional parameter $html in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php on line 1330

Deprecated: Required parameter $verp follows optional parameter $html in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php on line 1330

Deprecated: Required parameter $urls follows optional parameter $html in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php on line 1330

Deprecated: Required parameter $event_queue_id follows optional parameter $html in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php on line 1330

Deprecated: Required parameter $url_id follows optional parameter $job_id in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Mailing/Event/BAO/TrackableURLOpen.php on line 273

Deprecated: Required parameter $job follows optional parameter $is_domain in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Mailing/Event/BAO/Unsubscribe.php on line 302

Deprecated: Required parameter $activityParams follows optional parameter $contactDetails in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Activity/BAO/Activity.php on line 1267

Deprecated: Required parameter $activityID follows optional parameter $smsProviderParams in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Activity/BAO/Activity.php on line 1417

Deprecated: Required parameter $amount follows optional parameter $entityTable in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Price/BAO/LineItem.php on line 427

Before

Deprecations issued in php8

After

No deprecations

ping @eileenmcnaughton @totten

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

yep, agree