Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compat][phpunit8][NFC] Fix PHPUnit Warnings and fix a php error on f… #20477

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

seamuslee001
Copy link
Contributor

…unction declaration syntax in core extension tests

Overview

This fixes a few phpunit8 warnings generated

# Warning Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

This also fixes an error

Fatal error: Declaration of Civi\AfformMock\FormTestCase::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in /home/jenkins/bknix-edge/build/build-0/web/sites/all/modules/civicrm/ext/afform/mock/tests/phpunit/Civi/AfformMock/FormTestCase.php on line 32

Before

Warnings issued in phpunit8 and fatal error triggered

After

No warnings and no fatal error

ping @eileenmcnaughton @totten @demeritcowboy @colemanw

…unction declaration syntax in core extension tests
@seamuslee001
Copy link
Contributor Author

Jenkins test this please

@civibot
Copy link

civibot bot commented Jun 2, 2021

(Standard links)

@civibot civibot bot added the master label Jun 2, 2021
@seamuslee001 seamuslee001 merged commit 073a806 into civicrm:master Jun 2, 2021
@seamuslee001 seamuslee001 deleted the core_ext_phpunit8 branch June 2, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants