Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - Fix custom field handling and add tests #20480

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jun 2, 2021

Overview

This ensures custom fields are handled properly by Afform, including multi-record custom field groups & their autogenerated blocks, and contact reference fields.

Before

Custom contact reference fields not working in Afform.

After

Fixed

Comments

The bulk of this commit is unit tests :)

@civibot
Copy link

civibot bot commented Jun 2, 2021

(Standard links)

@civibot civibot bot added the master label Jun 2, 2021
This ensures custom fields are handled properly by Afform,
including multi-record custom field groups & their autogenerated blocks,
and contact reference fields.
@colemanw colemanw force-pushed the afformCustomFields branch from 61cc337 to 73cda6c Compare June 2, 2021 15:53
@seamuslee001 seamuslee001 self-assigned this Jun 2, 2021
@eileenmcnaughton
Copy link
Contributor

OK this looked pretty munted without this patch
image

& worked with it - i created a form & created a contact with a contact reference field & it worked

@eileenmcnaughton eileenmcnaughton merged commit 2bc3e01 into civicrm:master Jun 2, 2021
@eileenmcnaughton eileenmcnaughton deleted the afformCustomFields branch June 2, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants