Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Fix getFields to respect default_value from getFields #20481

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jun 2, 2021

Overview

A few fixes to make APIv4 getFields more internally consistent.

Technical Details

GetFields had an odd way of setting defaults for field metadata; this reuses the default_value property instead of declaring defaults in an ad-hoc fashion.

Also adds readonly to the table_name CustomGroup column, since that cannot be changed by the user.

GetFields had an odd way of setting defaults for field metadata;
this reuses the default_value property instead for more internal consistency.
@civibot
Copy link

civibot bot commented Jun 2, 2021

(Standard links)

@civibot civibot bot added the master label Jun 2, 2021
@eileenmcnaughton eileenmcnaughton merged commit a674c37 into civicrm:master Jun 2, 2021
@eileenmcnaughton eileenmcnaughton deleted the getFieldsFix branch June 2, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants