Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compat][NFC] Ensure that the 2nd parameter of hash_equals is a … #20483

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

seamuslee001
Copy link
Contributor

…string in authx

Overview

This fixes the following error when found running unit tests on php8

ERROR\n\n The website encountered an unexpected error. Please try again later. \n\nERROR MESSAGE\n\n _TypeError_: hash_equals(): Argument #2 ($user_string) must be of type\nstring, null given in _hash_equals()_ (line _161_ of\n_/home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/ext/authx/Civi/Authx/Authenticator.php_)

Before

Error found in unit tests

After

no error

Technical Details

A simple cast here should do the trick

ping @eileenmcnaughton @demeritcowboy @totten

@civibot
Copy link

civibot bot commented Jun 2, 2021

(Standard links)

@civibot civibot bot added the master label Jun 2, 2021
@seamuslee001 seamuslee001 merged commit 42dfe62 into civicrm:master Jun 2, 2021
@seamuslee001 seamuslee001 deleted the hash_equals_string branch June 2, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants