Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused variables and unnecessary initial setting of variables #20487

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Remove some unused variables and unnecessary initial setting of variables #20487

merged 1 commit into from
Jun 3, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove some unused variables

Before

image

After

silence of the vars

Technical Details

Comments

@civibot civibot bot added the master label Jun 3, 2021
@civibot
Copy link

civibot bot commented Jun 3, 2021

(Standard links)

@demeritcowboy
Copy link
Contributor

Agree with this but the PR title/description isn't right. They're not unused, but they all get set so soon and unconditionally/inevitably that setting an initial value is meaningless.

@demeritcowboy demeritcowboy merged commit 7642d69 into civicrm:master Jun 3, 2021
@demeritcowboy demeritcowboy changed the title Remove some unused variables Remove some unused variables and unnecessary initial setting of variables Jun 3, 2021
@eileenmcnaughton eileenmcnaughton deleted the cust_value branch June 3, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @demeritcowboy