Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF][php8-compat] Further fixes where there is a required paramater … #20490

Merged
merged 1 commit into from
Jun 3, 2021
Merged

[REF][php8-compat] Further fixes where there is a required paramater … #20490

merged 1 commit into from
Jun 3, 2021

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Jun 3, 2021 •
edited
Loading

…after an optional paramater

Overview

This fixes the following errors:

CiviCRM_API3_Exception: Required parameter $op follows optional parameter $joinTable

Deprecated: Required parameter $field follows optional parameter $daoName in /home/jenkins/bknix-edge/build/build-1/web/sites/all/modules/civicrm/CRM/Contact/BAO/Query.php on line 5907

Before

Errors triggered in php8 unit tests runs

After

Less errors

ping @eileenmcnaughton @totten @colemanw

@civibot
Copy link

civibot bot commented Jun 3, 2021

(Standard links)

@civibot civibot bot added the master label Jun 3, 2021
@eileenmcnaughton
Copy link
Contributor

My IDE has been whinging about these for years - good to see someone on the IDE's side

@seamuslee001 seamuslee001 merged commit 03604cc into civicrm:master Jun 3, 2021
@seamuslee001 seamuslee001 deleted the required_after_optional_fix branch June 3, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton