Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the issue that when you have membership with a contact reference custom field and the membership type is configured to be related that creating relationships fails.
See https://lab.civicrm.org/dev/membership/-/issues/37 for a more detailed report, including on how to reproduce.
Before
The membership was retrieved by the api which return values for contact reference fields as
custom_xx = 'Joe'
andcustom_xx_id = 202
.Those values where passed to the
Membership.create
parameters.After
Just before the values are passed to the
Membership.create
api the custom values are converted fromcustom_xx_id
tocustom_xx
.