[REF][php8-compat] Fix more instances of where there is a required pa… #20497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…rameter for a function after an optional one and fix an issue where by a NULL function property is treated as not exisiting in php8
seamuslee001
force-pushed
the
more_required_after_optional
branch
from
58e9bd4 to
47eea6b
Compare
| // return the stubbed permission (defaulting to true if the array is missing) | ||
| return is_array($this->permissions) ? in_array($str, $this->permissions) : TRUE; | ||
| return isset($this->permissions) && is_array($this->permissions) ? in_array($str, $this->permissions) : TRUE; |
There was a problem hiding this comment.
My personal pref is to clarify the groupings with brackets and it's not unheard of for php to change the order between versions (in fact in looks like there's a minor change for . in 8 - not relevant here), but ok this looks right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rameter for a function after an optional one and fix an issue where by a NULL function property is treated as not exisiting in php8
Overview
Title says it all
Before
PHP8 Errors generated in unit tests
After
Less PHP8 Errors generated
ping @eileenmcnaughton @totten @demeritcowboy