[php8-compat] fix Upgrade call back issues by making functions static… #20503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
upgrade_fixes
branch
from
61d86cb to
56519dc
Compare
| default: | ||
| throw new CRM_Extension_Exception("Cannot disable unknown extension: $key"); | ||
| if (isset($origStatuses[$key])) { | ||
| switch ($origStatuses[$key]) { |
There was a problem hiding this comment.
It looks like the intent was to throw an exception if something's missing - if that's not desired, could it log something instead?
There was a problem hiding this comment.
I've added in the Exception again for when it isn't set (which seems to be the case in the upgrades)
There was a problem hiding this comment.
Thanks. Looks good to me.
… and also fixing an issue with an array key not existing when checking obsolete extensions
seamuslee001
force-pushed
the
upgrade_fixes
branch
from
56519dc to
adcd515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and also fixing an issue with an array key not existing when checking obsolete extensions
Overview
This fixes call backs in php8 in the upgrade process by making the functions static and also fixing this notice error
Before
Upgrade Tests fail on php8
After
Upgrade tests work on php8
ping @eileenmcnaughton @totten @demeritcowboy