ACLEntityRole BAO tidy fixes #20504
Merged
ACLEntityRole BAO tidy fixes #20504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
monishdeb
commented
Jun 4, 2021
| * | ||
| * @param int $entityRoleId | ||
| * ID of the EntityRole record to be deleted. | ||
| * | ||
| */ | ||
| public static function del($entityRoleId) { | ||
| $entityDAO = new CRM_ACL_DAO_EntityRole(); |
There was a problem hiding this comment.
May be we should remove this function OR add a warning that says:
\CRM_Core_Error::deprecatedWarning(__CLASS__ . '::' . __FUNCTION__ . ' is deprecated, use ' . __CLASS__ . '::deleteRecord.' ); 
There was a problem hiding this comment.
Yeah - I think the api v3 would hit that? I'm happy to merge as is & we can look at that as a follow up
colemanw
reviewed
Jun 4, 2021
CRM/ACL/BAO/ACLEntityRole.php
Outdated
Comment on lines
75
to
87
| $entityDAO = new self(); | ||
| $entityDAO->id = $entityRoleId; | ||
| $entityDAO->find(TRUE); | ||
| $entityDAO->delete(); | ||
| } | ||
|
|
||
| /** | ||
| * @param array $record | ||
| * @return CRM_Contact_DAO_DashboardContact | ||
| * @throws CRM_Core_Exception | ||
| */ | ||
| public static function deleteRecord(array $record) { | ||
| return parent::deleteRecord($record); |
There was a problem hiding this comment.
Suggested change
| $entityDAO = new self(); | |
| $entityDAO->id = $entityRoleId; | |
| $entityDAO->find(TRUE); | |
| $entityDAO->delete(); | |
| } | |
| /** | |
| * @param array $record | |
| * @return CRM_Contact_DAO_DashboardContact | |
| * @throws CRM_Core_Exception | |
| */ | |
| public static function deleteRecord(array $record) { | |
| return parent::deleteRecord($record); | |
| return parent::deleteRecord(['id' => $entityRoleId]); |
monishdeb
force-pushed
the
add_aclrole_api4_entity
branch
from
57f6ced to
29a0c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Miscellaneous fixes on
Technical Details
Followup PR of #20474
Comments
ping @eileenmcnaughton @seamuslee001 @colemanw