Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compat][REF] Fix more php8 test failures caused by template issues #20517

Merged

Conversation

seamuslee001
Copy link
Contributor

Overview

This adds more fixes for template issues in tests fixing the following test:

  • CRM_Financial_Form_PaymentFormsTest::testEventPaymentForms
    Undefined array key "is_refund"

Before

Test failed on php8

After

Test passes on php8

ping @eileenmcnaughton @totten @demeritcowboy

@civibot
Copy link

civibot bot commented Jun 6, 2021

(Standard links)

@civibot civibot bot added the master label Jun 6, 2021
@seamuslee001 seamuslee001 force-pushed the php8_more_template_test_fixes branch from f3a78f7 to a221e1e Compare June 6, 2021 02:28
@eileenmcnaughton eileenmcnaughton merged commit 0f4f9ea into civicrm:master Jun 6, 2021
@eileenmcnaughton eileenmcnaughton deleted the php8_more_template_test_fixes branch June 6, 2021 05:57
@demeritcowboy
Copy link
Contributor

I think you need to also update civicrm_generated when message templates change? It looks like they're in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants