Fix v3 api payment test to validate on postAssert #20530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the test that was failing validation & moves the validation to class level
|
(Standard links)
|
|
@monishdeb wanna merge this #20532 - just test fixes to get away from invalid financial set up per #20531 |
|
Reviewed the patch, agree with the changes to rely on class to do validation checks. Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix v3 api payment test to validate on postAssert
Before
Refund test is passing a random value not a valid payment_id as 'cancelled payment_id'
After
Valid id
Technical Details
This fixes the test that was failing validation & moves the validation to class level
Comments