SearchKit - Fix link target selection #20537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I was able to replicate both the problem and the fix - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a recent SearchKit regression which broke the selector for choosing how a link would open (Normal/New Tab/Popup).
Before
Making a selection in this dropdown was ignored by the search display. Links would use default behavior regardless.
After
Fixed.
Technical Details
This also gets some templating logic out of the controller and into the template.
Also simplifies markup needed to open a link in a popup. Now both
class="crm-popup"andtarget="crm-popup"both work. The target attribute works better for search kit and is more semantic anyway.