[php8-compact] Add in guards into common templates to assit with fixi… #20543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng test failures on php8
|
(Standard links)
|
|
Code looks good. |
| @@ -9,7 +9,7 @@ | |||
| *} | |||
| {* Initialize jQuery validate on a form *} | |||
| {* Extra params and functions may be added to the CRM.validate object before this template is loaded *} | |||
| {if !$crm_form_validate_included and $smarty.get.snippet neq 'json' and $form and $form.formClass} | |||
| {if empty($crm_form_validate_included) and !empty($smarty.get.snippet) and $smarty.get.snippet neq 'json' and !empty($form) and !empty($form.formClass)} | |||
There was a problem hiding this comment.
@seamuslee001 I think this line isn't intended to change the behavior of the if statement, but it does - this prevents crmValidate() from being loaded on event registration pages:
and !empty($smarty.get.snippet)
This change causes the conditional to fail on event registration pages where previously it succeeded. I haven't found a scenario where that directly affects core, but it breaks CiviHoneypot and I wouldn't be surprised if there were configurations that could break core as well.
There was a problem hiding this comment.
@MegaphoneJon you are right - this looks like an unintentional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng test failures on php8
Overview
This adds in some if guards into various common templates to assist with some test failures in php8
Before
Tests can fail because of issues in templates
After
Tests fail for different reasons
ping @eileenmcnaughton @totten @demeritcowboy @colemanw